Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script improvement #3741

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Release script improvement #3741

merged 3 commits into from
Oct 25, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 25, 2024

A few improvement in the release script, please review commit per commit.

bmarty and others added 3 commits October 25, 2024 14:46
… again, without breaking the release script.

Previously any error in download_all_github_artifacts.py was ignored and the script was continuing (without success ofc).
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Oct 25, 2024
@bmarty bmarty marked this pull request as ready for review October 25, 2024 12:55
@bmarty bmarty requested a review from a team as a code owner October 25, 2024 12:55
@bmarty bmarty requested review from jmartinesp and removed request for a team October 25, 2024 12:55
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tXGse7

Copy link

sonarcloud bot commented Oct 25, 2024

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.05%. Comparing base (40d3fca) to head (8d81b36).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3741   +/-   ##
========================================
  Coverage    83.05%   83.05%           
========================================
  Files         1754     1754           
  Lines        43994    43994           
  Branches      5142     5142           
========================================
  Hits         36539    36539           
  Misses        5632     5632           
  Partials      1823     1823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 4b72429 into develop Oct 25, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/releaseImprovement branch October 25, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants